Skip to content

[stable2603] Backport #11417#11466

Merged
EgorPopelyaev merged 4 commits intostable2603from
backport-11417-to-stable2603
Mar 24, 2026
Merged

[stable2603] Backport #11417#11466
EgorPopelyaev merged 4 commits intostable2603from
backport-11417-to-stable2603

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #11417 into stable2603 from tdimitrov.

See the documentation on how to use this bot.

…ate` (#11417)

While testing the collator protocol revamp on westend I noticed
"Inconsistency while adding a leaf to the `ClaimQueueState`. Expected on
session change." pops up a lot at regular intervals.

Long story short, when writing this code I assumed that the CQ never
change but from a `ClaimQueueState` point of view this is not true. ~~On
session change the validators in the active set are reshuffled and end
up in different backing groups.~~ ON group rotation the validators are
assigned on a new core. In this case we start fetching the claim queue
for the newly assigned core and the future assignments in
`ClaimQueueState` are no longer valid so overwriting them is the right
thing to do.

We could also implement a logic which detects assignment change,
notifies the claim queue and cleans it up but it's an additional
complexity which doesn't add any benefits.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4afd7bd)
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Mar 23, 2026
@github-actions github-actions Bot requested a review from tdimitrov March 23, 2026 11:10
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) March 23, 2026 15:21
@EgorPopelyaev EgorPopelyaev merged commit dfb404c into stable2603 Mar 24, 2026
247 of 249 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-11417-to-stable2603 branch March 24, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants